Omer Frenkel has posted comments on this change.
Change subject: engine: Add/edit quota command
......................................................................
Patch Set 2: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
Line 21: super(parameters);
you have to set storagePoolId here or overwrite the getStoragePoolId, or the
permissionSubject method will never work, anyway dont forget to check if the
quota is null, in case you use it.
Line 30:
addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM.toString());
run vm?
Line 44: public Map<Guid, VdcObjectType> getPermissionCheckSubjects() {
please look at StorageHandlingCommandBase.getPermissionCheckSubjects()
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
Line 30:
addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM.toString());
so if its true: run vm!!!
and what happens if this method fails?
Line 46: return map;
maybe updating a quota should require a permission on the quota itself?
Line 50: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
should be edit
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddQuotaParameters.java
Line 29: }
why quota id and quota?
--
To view, visit http://gerrit.ovirt.org/1328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d932a312a51aafb9c4f80a549314b3c53890841
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
