Maor Lipchuk has posted comments on this change.
Change subject: engine: Add/edit quota command
......................................................................
Patch Set 2: (7 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
Line 21: super(parameters);
Done.
Line 30:
addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM.toString());
It was meant to be deleted, and count on the setActionMessageParameters()
instead.
Line 44: public Map<Guid, VdcObjectType> getPermissionCheckSubjects() {
Changed it.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
Line 30:
addCanDoActionMessage(VdcBllMessages.VAR__TYPE__VM.toString());
Agreed
Line 46: return map;
I wanted to avoid adding new vdcObjectType in this patch set, and do it in a
later patch set, since this will drag a change in the permissions.
Line 50: addCanDoActionMessage(VdcBllMessages.VAR__ACTION__ADD);
fixed
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddQuotaParameters.java
Line 29: }
This parameter class is for all the CRUD operations,
I was thinking that when delete will be called I will only use the quotaId
instead the client will send me the entire Quota entity.
Although the change of the class is quite misleading, I will change it to
QuotaCRUDParameters instead
--
To view, visit http://gerrit.ovirt.org/1328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d932a312a51aafb9c4f80a549314b3c53890841
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
