Michael Kublin has posted comments on this change. Change subject: engine: Add quota manager ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaManager.java Line 289: // For specific quota the quota which will be returned will be the same one (quotaID parameter). The following code will work only on single instance, not in cluster, because of lock in memory. But at any case, because of the best practice is to make a critical section small as possible, please move all select queries out of it, it is also no reason to put them inside cs (I did not find update in that class related to lock) -- To view, visit http://gerrit.ovirt.org/1749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia64ca54a53a3eab46b757bc67731077bc6d3a983 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
