Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota manager
......................................................................
Patch Set 1: (4 inline comments)
half reviewed
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaManager.java
Line 38: * concurrent map of quota locks, for each lock we preserve a
lock, to avoid full synchronization in each operation.
should it be "for each quota" ?
Line 57: public static void removeStorageDeltaQuotaCommand(Guid quotaId,
Guid storageDomainId, Guid commandId) {
its not clear what this method does, also, is this quota or quota limitation id
here?
Line 74: List<QuotaStorage> listQuotaStorage =
getQuotaDAO().getQuotaStorageByStorageGuid(storageDomainId, quotaId);
does this method return quota by storage? if so, why send quota id?
Line 287: // global (On
please fix formatting here
--
To view, visit http://gerrit.ovirt.org/1749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64ca54a53a3eab46b757bc67731077bc6d3a983
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
