Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota manager class
......................................................................
Patch Set 2: (3 inline comments)
this is not review-able
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaManager.java
Line 70: public static void removeStorageDeltaQuotaCommand(Guid quotaId,
Guid storageDomainId, QuotaEnforcmentTypeEnum quotaEnforcedType, Guid
commandId) {
its not clear what this method does, also, is this quota or quota limitation id
here?
Line 76: log.debugFormat("Found delta quota storage with id
{0} for command id {0}",
this will print the quota id twice
Line 94: public static void removeVdsGroupDeltaQuotaCommand(Guid quotaId,
Guid vdsGroupId, Guid commandId) {
same comments for this method
--
To view, visit http://gerrit.ovirt.org/1749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64ca54a53a3eab46b757bc67731077bc6d3a983
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
