Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: [autorecovery] Autorecovery logic
......................................................................
Patch Set 2: (8 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
Line 137: static boolean checkAuditLog(final long logInterval, final Guid
failId, Map<Guid, Date> counters) {
Not sure this is needed, please check the mechanism in AuditLogType (i.e-
AuditLogType.VDS_LOW_MEM)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
Line 372: @XmlElement(name="AutoRecoverable")
@XmlElement is not needed anymore, now that we use GWT.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 1249: @XmlElement(name = "AutoRecoverable")
Not needed anymore, now that we use GWT.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1092: AutoRecoveryAuditLogInterval(351),
Question - regarding the mechanism in AuditLogType - did you not use it as you
wanted it to be configurable? I see you added this entry in config , so I'm
wondering....
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AutoRecoverDAO.java
Line 4:
Nice idea :)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java
Line 249: return new SimpleJdbcTemplate(jdbcTemplate).query("select *
from storage_domains where recoverable and status = "
Can you please use stored procedure here?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
Line 121: return new SimpleJdbcTemplate(jdbcTemplate).query("select *
from vds where recoverable and status = "
Can you please use stored procedure here?
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/list/DoWithClosure.java
Line 3: public interface DoWithClosure<T, R> {
What is this?
--
To view, visit http://gerrit.ovirt.org/2011
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I544ff69bad946fd3d4edd2cf815ad10392958d26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
