Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: [autorecovery] Autorecovery logic
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
Line 44: private final static Map<Guid, Date> vdsCounters =
Collections.synchronizedMap(new HashMap<Guid, Date>());
Why not java.util.concurrent.ConcurrentMap ?
Line 137: static boolean checkAuditLog(final long logInterval, final Guid
failId, Map<Guid, Date> counters) {
Interesting points. I suggest you raise them upstream in email to engine-devel
about auto-recovery. I would like to hear more opinions here. We will continue
to review and advance on the feature in parallel.
--
To view, visit http://gerrit.ovirt.org/2011
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I544ff69bad946fd3d4edd2cf815ad10392958d26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
