Moti Asayag has posted comments on this change.
Change subject: engine-core: [autorecovery] Autorecovery logic
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java
Line 48: private final static Map<Guid, Date> storageDomainCunters =
Collections.synchronizedMap(new HashMap<Guid, Date>());
please fix typo - storageDomainCounters
Why do you rather Collections.synchronizedMap() over ConcurrentHashMap ?
Line 109: backend.runInternalAction(actionType, actionParams);
If this action should be monitored as a Task in the tasks view, you should
create a context for it, see for example from VdsEventListener:
public void StorageDomainNotOperational(Guid storageDomainId, Guid
storagePoolId) {
Backend.getInstance().runInternalAction(VdcActionType.HandleFailedStorageDomain,
new StorageDomainPoolParametersBase(storageDomainId,
storagePoolId),
ExecutionHandler.createInternalJobContext());
}
}
Line 137: static boolean checkAuditLog(final long logInterval, final Guid
failId, Map<Guid, Date> counters) {
What about adding parameter to AuditLogableBase like forceLog which force
logging regardless the time constraint:
See AuditLogDirector:
if (auditLogable == null || auditLogable.forceLog() || auditLogable.getLegal())
{
}
that way you could control it cross-wide. beyond the scope of a specific
command invocation (set default value which maintain current behaviour and
override it for specific needs).
--
To view, visit http://gerrit.ovirt.org/2011
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I544ff69bad946fd3d4edd2cf815ad10392958d26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
