Barak Azulay has posted comments on this change.
Change subject: packaging: Remote DB support
......................................................................
Patch Set 13: (9 inline comments)
please go over the comments
....................................................
File backend/manager/dbscripts/engine-db-install.sh
Line 70: l) LOGFILE=$OPTARG;;
whitespace
....................................................
File packaging/fedora/setup/common_utils.py
Line 323: if dbName != "none":
use empty string, it's more pythonic
so you can query
if not dbname:
....................................................
File packaging/fedora/setup/engine-setup.py
Line 1024: utils.execRemoteSqlCommand(getDbAdminUser(), getDbHostName(),
getDbPort(), "none", sqlQuery, True,
see comment on "none" string in common_utils
Line 1035: logging.debug("backing up %s db to file %s"%(basedefs.DB_NAME,
dbBackupFile))
replace order of backup and rename, otherwise the restore will happen into the
temp name
Line 1059:
Is this the correct error message ?
Line 1860: if getDbHostName() not in ("localhost", "127.0.0.1"):
change to the new function
Line 2356:
The above is a hack, so add a comment that this will always happen after the
handleParams
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 463: # Everything went fine, restore the DB name and fail if
there's a problem.
bad comment
....................................................
File packaging/fedora/setup/engine_validators.py
Line 142: def validateRemoteDB(param={}, options=[]):
change function name validateRemoteDBAccess
--
To view, visit http://gerrit.ovirt.org/2245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab66d6f8ffe33f9674e79753df7541c212012190
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Anonymous Coward #1000140
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
