Barak Azulay has posted comments on this change.
Change subject: packaging: Remote DB support
......................................................................
Patch Set 14: (2 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 323: if not dbName:
Condition should be opposite, isn't it ?
....................................................
File packaging/fedora/setup/engine_validators.py
Line 142: def validateRemoteDB(param={}, options=[]):
you didn't respond on this comment
"change function name validateRemoteDBAccess"
from patch set 13
--
To view, visit http://gerrit.ovirt.org/2245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab66d6f8ffe33f9674e79753df7541c212012190
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Anonymous Coward #1000140
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
