Ofer Schreiber has posted comments on this change.
Change subject: packaging: Remote DB support
......................................................................
Patch Set 17: Fails
(10 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 321: def execRemoteSqlCommand(userName, dbHost, dbPort, dbName, sqlQuery,
failOnError=False, errMsg=output_messages.ERR_SQL_CODE, pgTempPassFile=""):
pgTempPassFile un-needed
Line 578: cmd = "%s -h %s -p %s" % (cmd, host, port)
why do you need this if
Line 582: def restoreDB(db, user, host, port, backupFile):
where's the rename?
....................................................
File packaging/fedora/setup/engine-cleanup.py
Line 283: def exists(self):
please check what could be merged here
....................................................
File packaging/fedora/setup/engine-setup.py
Line 34: remoteInstallation = False
Please remove
Line 509: validFunc = param.getKey("VALIDATION_FUNC")
If we don't need this -> Please remove
Line 1370: if (type(validateFunc) == types.FunctionType and not
validateFunc(paramValue, optionsList)):
why we need this?
Line 1878: return
please check if needed
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 660: except Exception,e:
remove the Exception
....................................................
File packaging/fedora/setup/engine_validators.py
Line 133: def validateRemoteDB(param={}, options=[]):
1. Split
2. always rename back!
--
To view, visit http://gerrit.ovirt.org/2245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab66d6f8ffe33f9674e79753df7541c212012190
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Anonymous Coward #1000140
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
