Omer Frenkel has posted comments on this change.

Change subject: engine: add gluster volume id and name to audit log
......................................................................


Patch Set 1: (1 inline comment)

in reply to Shireesh comment: not sure i understand you, 
AuditLogDAODbFacadeImpl class has inner class AuditLogRowMapper for getting 
info from the db and method getSqlMapper to create parameters, so no duplicate 
code. did you refer to something else?

....................................................
File backend/manager/dbscripts/upgrade/03_01_0640_add_volume_to_audit_log.sql
Line 2: select fn_db_add_column('audit_log', 'gluster_volume_name', 
'VARCHAR(255)');
Done

--
To view, visit http://gerrit.ovirt.org/2793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c618f2adc0a753d595937586096abfdbc9ada3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to