Shireesh Anjal has posted comments on this change.
Change subject: engine: add gluster volume id and name to audit log
......................................................................
Patch Set 1: (1 inline comment)
Not directly related to this patch, but the source AuditLogDAODbFacadeImpl.java
has 4 copies of exactly same code for row mapper, and two copies of exactly
same code for parameterSource. Guess it would be nice to clean that up?
....................................................
File backend/manager/dbscripts/upgrade/03_01_0640_add_volume_to_audit_log.sql
Line 2: select fn_db_add_column('audit_log', 'gluster_volume_name',
'VARCHAR(255)');
Can we increase size of volume name column to 1000 ? That's the theoretical
limitation of a gluster volume name in GlusterFS.
--
To view, visit http://gerrit.ovirt.org/2793
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09c618f2adc0a753d595937586096abfdbc9ada3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
