Shireesh Anjal has posted comments on this change.

Change subject: engine: add gluster volume id and name to audit log
......................................................................


Patch Set 1:

In response to Omer's question:

The methods get, getAllAfterDate, getAllWithQuery and getAll  have code to 
create a ParameterizedRowMapper<AuditLog> that looks like (exactly same in all 
four cases):

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ParameterizedRowMapper<AuditLog> mapper = new 
ParameterizedRowMapper<AuditLog>() {
            @Override
            public AuditLog mapRow(ResultSet rs, int rowNum)
                    throws SQLException {
                AuditLog entity = new AuditLog();
                entity.setaudit_log_id(rs.getLong("audit_log_id"));
                ...
                return entity;
            }
        };
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Methods save and update use exactly same piece of code to create the 
MapSqlParameterSource before passing it to appropriate SP.

--
To view, visit http://gerrit.ovirt.org/2793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09c618f2adc0a753d595937586096abfdbc9ada3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to