Martin Peřina has posted comments on this change.

Change subject: core: Delays JNDI binding in Injector until needed
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Injector.java
Line 23:                 throw new RuntimeException("Couldn't locate a 
BeanManager instance due to " + e.getMessage()
Line 24:                         + " Actions will fail to perform due to 
runtime missing dependencies");
Line 25:             }
Line 26:         }
Line 27:         return manager;
I moved JNDI lookup to bindBeanManager() method, so now createCommand returns 
RuntimeException when BeanManager cannot be bound.
Line 28:     }
Line 29: 
Line 30:     @SuppressWarnings({ "rawtypes", "unchecked" })
Line 31:     public <T extends Object> void inject(T instance) {


-- 
To view, visit http://gerrit.ovirt.org/18904
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I776169e8f1b906395ef9290093c18aeaebf489db
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to