Sergey Gotliv has posted comments on this change.
Change subject: core: Delays JNDI binding in Injector until needed
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 127: * This method is called upon the bean creation as part of the
management Service bean lifecycle.
Line 128: */
Line 129: @PostConstruct
Line 130: public void create() {
Line 131: CommandsFactory.initCdi();
The code seems to be working. But I have a problem to explain myself the
Engine's initialization process.
This method is annotated with @PostConstruct.
According to PostConstruct documentation:
"The PostConstruct annotation is used on a method that needs to be executed
after dependency injection is done to perform any initialization"
In our case it looks like we initialize dependency injection in method which
supposed to be called after dependency injection is done...
Line 132: checkDBConnectivity();
Line 133: Initialize();
Line 134: }
Line 135:
--
To view, visit http://gerrit.ovirt.org/18904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I776169e8f1b906395ef9290093c18aeaebf489db
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
