Martin Peřina has posted comments on this change.

Change subject: core: Delays JNDI binding in Injector until needed
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
Line 45:     @SuppressWarnings("unchecked")
Line 46:     public static <P extends VdcActionParametersBase> CommandBase<P> 
CreateCommand(VdcActionType action, P parameters) {
Line 47:         // init CDI
Line 48:         injector.bindBeanManager();
Line 49: 
Sorry, Friday was not a good day for me. Fixed by calling from Backend.create()
Line 50:         try {
Line 51:             Constructor<CommandBase<? extends 
VdcActionParametersBase>> constructor =
Line 52:                     
findCommandConstructor(getCommandClass(action.name(), CommandSuffix), 
parameters.getClass());
Line 53: 


-- 
To view, visit http://gerrit.ovirt.org/18904
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I776169e8f1b906395ef9290093c18aeaebf489db
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to