Alon Bar-Lev has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 1: (2 comments) missing spec update for fedora 19, add Require statement and symlink. .................................................... File backend/manager/dependencies/src/main/modules/com/mchange/c3p0/main/module.xml Line 7: </resources> Line 8: Line 9: <dependencies> Line 10: <module name="javax.api"/> Line 11: </dependencies> slf4j? Line 12: .................................................... File ear/src/main/resources/META-INF/MANIFEST.MF are we sure we do not need only top level modules here? Line 1: Manifest-Version: 1.0 Line 2: Dependencies: asm.asm, Line 3: javax.validation.api, Line 4: org.aopalliance, -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
