Juan Hernandez has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 1: During runtime none of our 3rd party dependencies require aopalliance, c3p0, of xz, thus they aren't runtime dependencies. What you want to keep intact is the dependencies calculated by maven, and those are build time dependencies, not runtime dependencies, it is wrong to use them for runtime. -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
