Juan Hernandez has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 1: We don't need aopalliance, c3p0 or xz in the current implementation. If in the future someone needs to use xz, for example, that need should be justified, and only then it should be included, otherwise should by default be forbidden. The module dependencies should capture the runtime dependencies, and only those that we need. Any new dependency should be justified by a real need. -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
