Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: converted docs mapping files to properties ......................................................................
Patch Set 3: 1. why can't we store the format in json to begin with? A: We could. However, these files are hand-maintained by non-programmers, and I think the properties files are easier to edit by hand -- less chance of messing up because there is almost no syntax to get right. 2. we do not need to commit file with just empty values if we provide a script to generate a complete file. A: We need at least a blank file to prevent the 404s (this was originally your idea). Further, I think it's nice to have all the tokens in the file because it 1. makes less work for the doc team, and 2. acts as a nice template in case people in the oVirt community want to add context-sensitive help. Having the tags in the file already lowers the barrier. 3. please consider to move the servlets out of /manual name space. A: Sure, where to? 4. please consider to use the branding application name as a key to which file to load. A: I don't follow. -- To view, visit http://gerrit.ovirt.org/20793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b96d005684007125d5f3940abdbec25d4cae81f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
