Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: converted docs mapping files to properties ......................................................................
Patch Set 3: 1. well, these files are maintained by professionals anyway, so I think the lest conversions we do the best. 2. we should commit empty (zero size) file, the purpose of that file is not to serve as template but allow errorless runtime. to create a template we can use the script provided. There is no sense in in committing new version of the index every time a commit adds a new help in application. 3. root of /doc? 4. instead of having hard coded name of the properties file use the branding application name as name... it should be available if I am not mistaken. Thanks! -- To view, visit http://gerrit.ovirt.org/20793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b96d005684007125d5f3940abdbec25d4cae81f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
