Liron Ar has posted comments on this change.
Change subject: engine: Force VdsDynamic update on status change
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 370: * @param dynamicData
Line 371: */
Line 372: public void UpdateDynamicData(VdsDynamic dynamicData) {
Line 373: if (dynamicData != null && _vds != null &&
_vds.getDynamicData() != null
Line 374: && (!dynamicData.equals(_vds.getDynamicData()) ||
dynamicData.getprevious_status() != dynamicData.getStatus())) {
status check only is error prone, there are many different calls in that flow
that calls _vdsDynamic.Set.. and might update different things than the status
, i think that making this change may cause regressions - take a look at the
call to refreshCapabilities with _vds for exmaple which will cause issues.
Line 375:
DbFacade.getInstance().getVdsDynamicDao().update(dynamicData);
Line 376: } else {
Line 377: log.debug("Ignoring unneeded update of VDSDynamic");
Line 378: }
--
To view, visit http://gerrit.ovirt.org/21171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8814330970f467cc1c5170975efe192628ad365f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
