Liron Ar has posted comments on this change.
Change subject: engine: Force VdsDynamic update on status change
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 127: private static final String EXTERNAL_VM_NAME_FORMAT =
"external-%1$s";
Line 128:
Line 129: private void saveDataToDb() {
Line 130: if (_saveVdsDynamic) {
Line 131:
_vdsManager.UpdateDynamicDataVerify(_vds.getDynamicData());
that still won't work, as i wrote in previous patchset:
take a look at the call to refreshCapabilities with _vds -
refreshVdsRunTimeInfo(), take a look from where that save method is being
called.
if we are trying to implement hibernate like solution for discovering "dirty"
objects, the solution should be generic to the whole system if we don't want to
use hibernate/framework that already provides that implementation.
Line 132: }
Line 133:
Line 134: if (_saveVdsStatistics) {
Line 135: VdsStatistics stat = _vds.getStatisticsData();
--
To view, visit http://gerrit.ovirt.org/21171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8814330970f467cc1c5170975efe192628ad365f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
