Liran Zelkha has posted comments on this change.
Change subject: engine: Force VdsDynamic update on status change
......................................................................
Patch Set 3:
(3 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 364: }
Line 365: }
Line 366:
Line 367: /**
Line 368: * Save dynamic data to DB if different from cache
Yes, I understand. This is really bad logic here. Getting an object and
updating the object someplace else. I'll find another solution.
Line 369: * @param dynamicData
Line 370: */
Line 371: public void UpdateDynamicDataVerify(VdsDynamic dynamicData) {
Line 372: if (dynamicData != null && _vds != null &&
_vds.getDynamicData() != null
Line 381: * Save dynamic data to cache and DB.
Line 382: * @param dynamicData
Line 383: */
Line 384: public void UpdateDynamicData(VdsDynamic dynamicData) {
Line 385: log.debug("Updated VDS dynamic without checking if update is
needed");
Done
Line 386: DbFacade.getInstance().getVdsDynamicDao().update(dynamicData);
Line 387: }
Line 388:
Line 389: /**
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 127: private static final String EXTERNAL_VM_NAME_FORMAT =
"external-%1$s";
Line 128:
Line 129: private void saveDataToDb() {
Line 130: if (_saveVdsDynamic) {
Line 131:
_vdsManager.UpdateDynamicDataVerify(_vds.getDynamicData());
Yes, I'll find another solution.
Line 132: }
Line 133:
Line 134: if (_saveVdsStatistics) {
Line 135: VdsStatistics stat = _vds.getStatisticsData();
--
To view, visit http://gerrit.ovirt.org/21171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8814330970f467cc1c5170975efe192628ad365f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
