Omer Frenkel has posted comments on this change.
Change subject: engine: Delete Gluster Volume
......................................................................
Patch Set 2: (1 inline comment)
in addition to Shireesh comments,
missing also translation for can do action message (in apperrors.properties)
please make sure you dont miss any file, as listed in
www.ovirt.org/wiki/Engine_Adding_Messages
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommand.java
Line 32: if(! super.canDoAction()) {
on your next rebase, please format the spaces correctly:
should be:
if (!su...)
instead of
if(! su..)
--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0d89c7100d787a4c66c29b2c1cc0832c494b33
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
