Shireesh Anjal has posted comments on this change. Change subject: engine: Delete Gluster Volume ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java Line 264: DeleteGlusterVolume(1403, ActionGroup.DELETE_GLUSTER_VOLUME), There was a discussion in engine-devel mailing list where it was recommended to leave a comma before the semicolon, which supposedly makes life easier when merging because one can introduce a new enum at the end without changing the existing last line of the enum definition. http://lists.ovirt.org/pipermail/engine-devel/2012-April/001315.html .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java Line 134: DeleteGlusterVolume("org.ovirt.engine.core.vdsbroker.gluster"), please refer to my response on the previous comment. -- To view, visit http://gerrit.ovirt.org/3744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide0d89c7100d787a4c66c29b2c1cc0832c494b33 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <[email protected]> Gerrit-Reviewer: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
