Shireesh Anjal has posted comments on this change.

Change subject: engine: Delete Gluster Volume
......................................................................


Patch Set 5: No score

Entries in AppErrors.java and VdsmErrors.java (frontend project) missing.

Looks like my comment on patch-set 3 was wrong! I just found out that 
userportal build would fail if entries are added to AppErrors.java but not in 
AppErrors.properties of userportal.

So even if you are not concerned with the userportal project, you must add 
entries to the userportal project's AppErrors.properties as well. Please add it 
back :)

--
To view, visit http://gerrit.ovirt.org/3744
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide0d89c7100d787a4c66c29b2c1cc0832c494b33
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to