Daniel Erez has posted comments on this change.
Change subject: frontend: prevent unboxing of integer in AsyncDataProvider
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 3419: }
Line 3420:
Line 3421: public static Integer getMaxVmNameLengthWin() {
Line 3422: Integer maxVmNameLengthWindows = (Integer)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthWindows);
Line 3423: if(maxVmNameLengthWindows == null) {
formatter
Line 3424: return 15;
Line 3425: }
Line 3426: return maxVmNameLengthWindows;
Line 3427: }
Line 3420:
Line 3421: public static Integer getMaxVmNameLengthWin() {
Line 3422: Integer maxVmNameLengthWindows = (Integer)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthWindows);
Line 3423: if(maxVmNameLengthWindows == null) {
Line 3424: return 15;
Unrelated to the patch - this should probably be replaced with a query to
OsRepository (i.e. use OsInfo infrastructure). Anyway, I'm not sure we still
need to maintain these fallback values or at least extract to constants - but
again, good enough to resolve the findbugs issue.
Line 3425: }
Line 3426: return maxVmNameLengthWindows;
Line 3427: }
Line 3428:
Line 3427: }
Line 3428:
Line 3429: public static Integer getMaxVmNameLengthNonWin() {
Line 3430: Integer maxVmNameLengthNonWindows = (Integer)
AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.MaxVmNameLengthNonWindows);
Line 3431: if(maxVmNameLengthNonWindows == null) {
same
Line 3432: return 64;
Line 3433: }
Line 3434: return maxVmNameLengthNonWindows;
Line 3435: }
--
To view, visit http://gerrit.ovirt.org/21635
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c673f3afddb48b9982d3448f3603002e7a8cf6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
