Alissa Bonas has posted comments on this change. Change subject: frontend: prevent unboxing of integer in AsyncDataProvider ......................................................................
Patch Set 1: you mean FB warning :) It is not complaining on the "plain" values there (15, 64), but rather on the unboxing of the maxVmNameLengthWindows/maxVmNameLengthNonWindows variable in the return expression when evaluated along the "plain" numbers. So by not evaluating them together in the same expression, there is no unboxing. I ran findbugs locally, it makes those warnings go away. -- To view, visit http://gerrit.ovirt.org/21635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c673f3afddb48b9982d3448f3603002e7a8cf6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
