Sergey Gotliv has posted comments on this change.
Change subject: engine: Split nfs and iscsi logic when creating storage
connection
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 80: conParams.put("port", connection.getport(), "");
Line 81: conParams.put("iqn", connection.getiqn(), "");
Line 82: conParams.put("user", connection.getuser_name(), "");
Line 83: conParams.put("password", connection.getpassword(),
"");
Line 84: break;
I still have to verify that user and password are not used by any other
connection type.
Line 85:
Line 86: case NFS:
Line 87: // storage_pool can be null when discovering iscsi
send targets or when connecting
Line 88: // through vds which has no storage pool
--
To view, visit http://gerrit.ovirt.org/21971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba33ea1b40ef1eb9c74cad7b0531dc26e21c049a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
