Allon Mureinik has posted comments on this change.
Change subject: engine: Split nfs and iscsi logic when creating storage
connection
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 90:
storagePool.getcompatibility_version().getValue())) {
Line 91: // For mnt_options, vfs_type, and protocol_version
- if they are null
Line 92: // or empty we should not send a key with an empty
value
Line 93: conParams.putIfNotEmpty("mnt_options",
connection.getMountOptions());
Line 94: conParams.putIfNotEmpty("vfs_type",
connection.getVfsType());
something's not right here (seems like it also exists in the code before the
patch too), but mnt_options and vfs_type are relevant to posix too.
Line 95: if (connection.getNfsVersion() != null) {
Line 96: conParams.put("protocol_version",
connection.getNfsVersion().getValue());
Line 97: }
Line 98: conParams.putIfNotEmpty("timeout",
connection.getNfsTimeo());
--
To view, visit http://gerrit.ovirt.org/21971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba33ea1b40ef1eb9c74cad7b0531dc26e21c049a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
