Alissa Bonas has posted comments on this change. Change subject: engine: Split nfs and iscsi logic when creating storage connection ......................................................................
Patch Set 1: (2 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-12-03 16:45:55 +0200 Line 4: Commit: Sergey Gotliv <[email protected]> Line 5: CommitDate: 2013-12-03 16:45:55 +0200 Line 6: Line 7: engine: Split nfs and iscsi logic when creating storage connection The title is misleading, the connection is not created (added to system) here. And the changed command is connectStorage, not AddStorageServerConnection. Line 8: Line 9: Change-Id: Iba33ea1b40ef1eb9c74cad7b0531dc26e21c049a .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java Line 90: storagePool.getcompatibility_version().getValue())) { Line 91: // For mnt_options, vfs_type, and protocol_version - if they are null Line 92: // or empty we should not send a key with an empty value Line 93: conParams.putIfNotEmpty("mnt_options", connection.getMountOptions()); Line 94: conParams.putIfNotEmpty("vfs_type", connection.getVfsType()); +1 on Allon's comment. missing usecase for Posix. Line 95: if (connection.getNfsVersion() != null) { Line 96: conParams.put("protocol_version", connection.getNfsVersion().getValue()); Line 97: } Line 98: conParams.putIfNotEmpty("timeout", connection.getNfsTimeo()); -- To view, visit http://gerrit.ovirt.org/21971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba33ea1b40ef1eb9c74cad7b0531dc26e21c049a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
