Sandro Bonazzola has uploaded a new change for review. Change subject: packaging: setup: rollback legacy sysconfig ......................................................................
packaging: setup: rollback legacy sysconfig On failure, after rollback, /etc/sysconfig/ovirt-engine was empty and previous version was in /etc/sysconfig/ovirt-engine.rpmsave. Rolling back also /etc/sysconfig/ovirt-engine on cleanup after failure. Change-Id: Ie9e4a90a7e0e47aeb88a938fedb4f2088d533a70 Bug-Url: https://bugzilla.redhat.com/1049622 Signed-off-by: Sandro Bonazzola <[email protected]> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/23071/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py index 7e40b99..a18a083 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py +++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py @@ -150,6 +150,23 @@ ) @plugin.event( + stage=plugin.Stages.STAGE_CLEANUP, + condition=lambda self: self.environment[ + osetupcons.CoreEnv.UPGRADE_FROM_LEGACY + ], + ) + def _cleanup(self): + legacy = osetupcons.FileLocations.LEGACY_OVIRT_ENGINE_SYSCONFIG + legacy_rpmsave = legacy + '.rpmsave' + # yum update renamed it. Here we rename back for completing + # yum rollback + if ( + self.environment[otopicons.BaseEnv.ERROR] and + os.path.exists(legacy_rpmsave) + ): + os.rename(legacy_rpmsave, legacy) + + @plugin.event( stage=plugin.Stages.STAGE_CLOSEUP, condition=lambda self: self.environment[ osetupcons.CoreEnv.UPGRADE_FROM_LEGACY -- To view, visit http://gerrit.ovirt.org/23071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie9e4a90a7e0e47aeb88a938fedb4f2088d533a70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
