Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: rollback legacy sysconfig
......................................................................
Patch Set 2:
(2 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py
Line 130: # backup sysconfig before yum transaction, allowing
rollback.
Line 131: self._backup = '%s.%s' % (
Line 132:
osetupcons.FileLocations.LEGACY_OVIRT_ENGINE_SYSCONFIG,
Line 133: datetime.datetime.now().strftime('%Y%m%d%H%M%S'),
Line 134: )
better to use temp file
Line 135: shutil.copy2(
Line 136:
osetupcons.FileLocations.LEGACY_OVIRT_ENGINE_SYSCONFIG,
Line 137: self._backup
Line 138: )
Line 134: )
Line 135: shutil.copy2(
Line 136:
osetupcons.FileLocations.LEGACY_OVIRT_ENGINE_SYSCONFIG,
Line 137: self._backup
Line 138: )
but why not read into memory? because you want to rename later? ok...
Line 139:
Line 140: @plugin.event(
Line 141: stage=plugin.Stages.STAGE_MISC,
Line 142: condition=lambda self: self.environment[
--
To view, visit http://gerrit.ovirt.org/23071
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e4a90a7e0e47aeb88a938fedb4f2088d533a70
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
