Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: rollback legacy sysconfig ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/config.py Line 163: if ( Line 164: self.environment[otopicons.BaseEnv.ERROR] and Line 165: os.path.exists(legacy_rpmsave) Line 166: ): Line 167: os.rename(legacy_rpmsave, legacy) scary! so you always overwrite the legacy with rpmsave? what if the rpmsave is of oooooooold installation? maybe better to remove it before procedure starts to make sure this is ours? or just manually backup current file and restore in failure? Line 168: Line 169: @plugin.event( Line 170: stage=plugin.Stages.STAGE_CLOSEUP, Line 171: condition=lambda self: self.environment[ -- To view, visit http://gerrit.ovirt.org/23071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9e4a90a7e0e47aeb88a938fedb4f2088d533a70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
