Alon Bar-Lev has posted comments on this change.

Change subject: tools: support snmp trap as a notification method.
......................................................................


Patch Set 13:

(3 comments)

http://gerrit.ovirt.org/#/c/22909/13/backend/manager/tools/pom.xml
File backend/manager/tools/pom.xml:

Line 19:   <description>oVirt Engine Tools</description>
Line 20: 
Line 21:   <repositories>
Line 22:   </repositories>
Line 23: 
????????????
Line 24:   <dependencies>
Line 25: 
Line 26:     <dependency>
Line 27:       <groupId>org.snmp4j</groupId>


http://gerrit.ovirt.org/#/c/22909/13/ovirt-engine.spec.in
File ovirt-engine.spec.in:

Line 207: Requires:     springframework-instrument
Line 208: Requires:     springframework-jdbc
Line 209: Requires:     springframework-tx
Line 210: Requires:     xmlrpc-client
Line 211: Requires:     snmp4j
please sort block
Line 212: %endif
Line 213: %endif
Line 214: 
Line 215: # We can't require exactly the same version and release of the


http://gerrit.ovirt.org/#/c/22909/13/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in:

Line 109: SNMP_COMMUNITY=public
Line 110: 
Line 111: # Object Identifier identifying ovirt engine SNMP trap messages.
Line 112: SNMP_OID=1.3.6.1.4.1.2312.13.1
Line 113: # 
1[iso].3[organization].6[DoD].1[Internet].4[private].1[enterprises].2312[redhat].13[ovirt-engine].1[audit-log]
please add 1[notification].1[audit-log]

we may need to provide decent audit-log from the event interface in future, and 
probably at different format.
Line 114: 
Line 115: # comma separated list of event names to notify on.
Line 116: #WHITELIST=""
Line 117: 


-- 
To view, visit http://gerrit.ovirt.org/22909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to