Alon Bar-Lev has posted comments on this change.

Change subject: tools: support snmp trap as a notification method.
......................................................................


Patch Set 14:

> Regarding event filters I wanna make sure I understand: FILTER=include:eventA 
> eventB For whitelist and FILTER=exclude: eventC For black? and if the value 
> is empty/non existing I do my default (==FILTER='exclude:')

I just gave one option that is less confusing than what you had... another 
option is:

 FILTER_MODE=exclude|include
 FILTER=

what I do not want is two options that implicit state something if exists/have 
value and may conflict each other.

-- 
To view, visit http://gerrit.ovirt.org/22909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to