Alon Bar-Lev has posted comments on this change. Change subject: tools: support snmp trap as a notification method. ......................................................................
Patch Set 14: > Alon: Regarding the Auxiliary snmp managers I would prefer to do it in a > separate patch. Regarding WHITELIST commented out Do you see my problem? " I > was required to: There is no much sense to add a functionality then alter it for known issues. Especially if this is trivial and modify the configuration format. > 1.) Have whitelist on higher precedence then blacklist. 2.) By default send > all events. commenting out WHITELIST was the best solution I came up with. > What do you want done here? " > If missing variable == empty one. I think it implies i must change > WhiteL/BlackL precedence OR send no events on default? provide a solution that confirm to the usage of this file. example: FILTER=include:statement exclude:statement -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
