Liron Ar has posted comments on this change. Change subject: core: Avoid unnecessary VDSM update pool calls when no domains in pool ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/23410/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 56: @Override Line 57: protected void executeCommand() { Line 58: updateQuotaCache(); Line 59: if (_oldStoragePool.getStatus() == StoragePoolStatus.Up && getMasterDomain() != null) { Line 60: if (!StringUtils.equals(_oldStoragePool.getName(), getStoragePool().getName())) { the pool can't be up if there's no master domain. Line 61: runVdsCommand(VDSCommandType.SetStoragePoolDescription, Line 62: new SetStoragePoolDescriptionVDSCommandParameters( Line 63: getStoragePool().getId(), getStoragePool().getName()) Line 64: ); Line 107: new TransactionMethod<Object>() { Line 108: @Override Line 109: public Object runInTransaction() { Line 110: getStoragePoolDAO().updatePartial(storagePool); Line 111: if (getMasterDomain() != null) { why? Line 112: updateMemberDomainsFormat(targetFormat); Line 113: } Line 114: return null; Line 115: } Line 115: } Line 116: }); Line 117: Line 118: if (_oldStoragePool.getStatus() == StoragePoolStatus.Up && getMasterDomain() != null) { Line 119: try { same as above Line 120: // No need to worry about "reupgrading" as VDSM will silently ignore Line 121: // the request. Line 122: runVdsCommand(VDSCommandType.UpgradeStoragePool, Line 123: new UpgradeStoragePoolVDSCommandParameters(spId, targetFormat)); -- To view, visit http://gerrit.ovirt.org/23410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8302972bb21fa076cd35fb308f5f660ca9200daa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
