Liron Ar has posted comments on this change. Change subject: core: Add storage types to DiskImage entity ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/23410/5/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 167: SELECT 0 AS disk_storage_type, Line 168: storage_for_image_view.storage_id as storage_id, -- Storage fields Line 169: storage_for_image_view.storage_path as storage_path, Line 170: storage_for_image_view.storage_name as storage_name, Line 171: storage_for_image_view.storage_type as storage_type, > you should also add it to all_disks view otherwise you will fail in the eng ignore Line 172: storage_pool_id, Line 173: image_guid, -- Image fields Line 174: creation_date, Line 175: actual_size, -- To view, visit http://gerrit.ovirt.org/23410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8302972bb21fa076cd35fb308f5f660ca9200daa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
