Allon Mureinik has posted comments on this change. Change subject: core: Add storage types to DiskImage entity ......................................................................
Patch Set 6: Code-Review+2 (3 comments) /minor/ comments inline http://gerrit.ovirt.org/#/c/23410/6//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-01-21 11:29:04 +0200 Line 6: Line 7: core: Add storage types to DiskImage entity Line 8: Line 9: Currently DiskImage has a storageIds fields that contains a list of the s/has a storageIds fields/has a storageIds field/ Line 10: storages it resides on, it makes sense also to add a storage types field Line 11: to avoid having to fetch the storage domain in order to know which storage Line 12: type the disk resides on. Line 13: This will be helpful when the storage pool storage type property will be Line 6: Line 7: core: Add storage types to DiskImage entity Line 8: Line 9: Currently DiskImage has a storageIds fields that contains a list of the Line 10: storages it resides on, it makes sense also to add a storage types field s/on, it/on. It/ s/also to add/to also add/ Line 11: to avoid having to fetch the storage domain in order to know which storage Line 12: type the disk resides on. Line 13: This will be helpful when the storage pool storage type property will be Line 14: removed. http://gerrit.ovirt.org/#/c/23410/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java: Line 193: try { Line 194: types.add(StorageType.forValue(Integer.parseInt(typeStr))); Line 195: } Line 196: catch (NumberFormatException e) { Line 197: throw new SQLException("Could not parse disk image storage domain type " + typeStr); add e as the cause argument. Line 198: } Line 199: } Line 200: return types; Line 201: } -- To view, visit http://gerrit.ovirt.org/23410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8302972bb21fa076cd35fb308f5f660ca9200daa Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
