Martin Peřina has posted comments on this change. Change subject: tools: Support snmp trap as a notification method. ......................................................................
Patch Set 17: (3 comments) http://gerrit.ovirt.org/#/c/22909/17/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 140: */ Line 141: public void validate() { Line 142: validateCommon(); Line 143: Line 144: validateEmailBasic(); This should be called only if MAIL_SERVER is entered Line 145: if (isConfigured(NotificationProperties.MAIL_SERVER)) { Line 146: validateEmailAvailability(); Line 147: } Line 148: validateSNMPBasic(); Line 184: } Line 185: Line 186: private void validateEmailBasic() { Line 187: // validate MAIL_PORT Line 188: requireAll(MAIL_PORT); Please add here mail port validation, you dropped this by mistake on rebase Line 189: Line 190: // validate MAIL_USER value Line 191: String emailUser = getProperty(NotificationProperties.MAIL_USER, true); Line 192: if (StringUtils.isEmpty(emailUser) Line 317: /** Line 318: * Returns {@code true} if mail transport encryption type is correctly specified, Line 319: * otherwise {@code false} Line 320: */ Line 321: public boolean isSMTPEncryptionOptionValid() { Please undo this renaming Line 322: return MAIL_SMTP_ENCRYPTION_NONE.equals(getProperty(MAIL_SMTP_ENCRYPTION, true)) Line 323: || MAIL_SMTP_ENCRYPTION_SSL.equals(getProperty(MAIL_SMTP_ENCRYPTION, true)) Line 324: || MAIL_SMTP_ENCRYPTION_TLS.equals(getProperty(MAIL_SMTP_ENCRYPTION, true)); Line 325: } -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
