Liran Zelkha has posted comments on this change. Change subject: engine: Numa feature ......................................................................
Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/23702/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 1038: Line 1039: public void setNumaNodes(String value) { Line 1040: this.mVdsDynamic.setnuma_nodes(value); Line 1041: } Line 1042: Please make sure you add these to the equals and hashCode methods as well Line 1043: public void setIScsiInitiatorName(String value) { Line 1044: this.mVdsDynamic.setIScsiInitiatorName(value); Line 1045: } Line 1046: http://gerrit.ovirt.org/#/c/23702/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java: Line 1547: Line 1548: public void setVmNumaTopo(String vmNumaTopo) { Line 1549: vmStatic.setVmNumaTopo(vmNumaTopo); Line 1550: } Line 1551: Please make sure you add these to the equals and hashCode methods as well Line 1552: public boolean isBalloonEnabled() { Line 1553: return balloonEnabled; Line 1554: } Line 1555: http://gerrit.ovirt.org/#/c/23702/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 84: private String kernel_version; Line 85: Line 86: private String iScsiInitiatorName; Line 87: Line 88: private String numa_nodes; Can the numa_nodes change in a host life cycle? I mean - should this be stored in vds_dynamic or vds_static? Line 89: Line 90: private VdsTransparentHugePagesState transparentHugePagesState; Line 91: Line 92: @Size(max = BusinessEntitiesDefinitions.GENERAL_NAME_SIZE) Line 537: Line 538: public void setnuma_nodes(String value) { Line 539: this.numa_nodes = value; Line 540: } Line 541: Please make sure you add these to the equals and hashCode methods as well Line 542: public RpmVersion getGlusterVersion() { Line 543: return this.glusterVersion; Line 544: } Line 545: http://gerrit.ovirt.org/#/c/23702/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java: Line 53: Line 54: @EditableField Line 55: @OvfExportOnlyField(exportOption = ExportOption.EXPORT_NON_IGNORED_VALUES) Line 56: @Size(max = BusinessEntitiesDefinitions.VM_NUMA_TOPO_SIZE) Line 57: private String vmNumaTopo; Please make sure you add these to the equals and hashCode methods as well Line 58: Line 59: @EditableField Line 60: private boolean useHostCpuFlags; Line 61: -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
