Yair Zaslavsky has posted comments on this change. Change subject: engine: Numa feature ......................................................................
Patch Set 4: Hi, A quick question here - sorry if it sounds like I'm insisting - at VmStatic you added new columns, and you reflected that at VmStaticDaoDbFacadeImpl , and in vms_sp.sql. The insert related stored procedure for vm static got changed as well. If you increased the number of columns of vm_static, this should have been reflected, in my humble opinion, at fixtures.xml as well, as it must have the same columns number per each table fixture as defined in db. Can you please elaborate on that? -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
