Yair Zaslavsky has posted comments on this change. Change subject: engine: Numa feature ......................................................................
Patch Set 2: (3 comments) Where are the changes to the relevant DAO tests? http://gerrit.ovirt.org/#/c/23702/2/packaging/dbscripts/create_views.sql File packaging/dbscripts/create_views.sql: Line 611: vm_static.default_display_type as default_display_type, vm_static.priority as priority,vm_static.iso_path as iso_path, vm_static.origin as origin, vds_groups.compatibility_version as vds_group_compatibility_version, Line 612: vm_static.initrd_url as initrd_url, vm_static.kernel_url as kernel_url, vm_static.kernel_params as kernel_params, vm_dynamic.pause_status as pause_status, vm_dynamic.exit_message as exit_message, vm_dynamic.exit_status as exit_status,vm_static.migration_support as migration_support,vm_static.predefined_properties as predefined_properties,vm_static.userdefined_properties as userdefined_properties,vm_static.min_allocated_mem as min_allocated_mem, vm_dynamic.hash as hash, vm_static.cpu_pinning as cpu_pinning, vm_static.db_generation as db_generation, vm_static.host_cpu_flags as host_cpu_flags, Line 613: vm_static.tunnel_migration as tunnel_migration, vm_static.vnc_keyboard_layout as vnc_keyboard_layout, vm_static.is_run_and_pause as is_run_and_pause, vm_static.created_by_user_id as created_by_user_id, Line 614: vm_dynamic.last_watchdog_event as last_watchdog_event, vm_dynamic.last_watchdog_action as last_watchdog_action, vm_dynamic.is_run_once as is_run_once, vm_dynamic.vm_fqdn as vm_fqdn, vm_dynamic.cpu_name as cpu_name, Line 615: vm_static.instance_type_id as instance_type_id, vm_static.image_type_id as image_type_id, vds_groups.architecture as architecture, vm_static.original_template_id as original_template_id, vm_static.original_template_name as original_template_name, vm_dynamic.last_stop_time as last_stop_time, trailing whitespace, please remove. Line 616: vm_static.numa_type as numa_type, vm_static.mem_numa_node as mem_numa_node, vm_static.vm_numa_topo as vm_numa_topo, Line 617: vm_static.migration_downtime as migration_downtime, vm_static.template_version_number as template_version_number Line 618: FROM vm_static INNER JOIN Line 619: vm_dynamic ON vm_static.vm_guid = vm_dynamic.vm_guid INNER JOIN http://gerrit.ovirt.org/#/c/23702/2/packaging/dbscripts/upgrade/03_05_0010_add_numa.sql File packaging/dbscripts/upgrade/03_05_0010_add_numa.sql: Line 1: Line 2: select fn_db_add_column('vm_static', 'numa_type', 'INTEGER default 0'); Line 3: select fn_db_add_column('vm_static', 'mem_numa_node', 'varchar(255) default null'); Line 4: select fn_db_add_column('vm_static', 'vm_numa_topo', 'varchar(4000) default null'); 4000 is enough? may I suggest text data type here? Line 5: select fn_db_add_column('vds_dynamic', 'numa_nodes', 'varchar(255) default null'); http://gerrit.ovirt.org/#/c/23702/2/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 443: v_quota_id UUID, Line 444: v_cpu_pinning VARCHAR(4000), Line 445: v_numa_type INTEGER, Line 446: v_mem_numa_node VARCHAR(255), Line 447: v_numa_topo VARCHAR(4000), same question about text data type Line 448: v_host_cpu_flags BOOLEAN, Line 449: v_tunnel_migration BOOLEAN, Line 450: v_vnc_keyboard_layout VARCHAR(16), Line 451: v_is_run_and_pause BOOLEAN, -- To view, visit http://gerrit.ovirt.org/23702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifefade432e7955503980bdc6fc5d73ea32818a95 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
