Greg Sheremeta has posted comments on this change.
Change subject: userportal, webadmin: refactor: add model attribute for help
tags
......................................................................
Patch Set 7:
@Vojtech, @Alon, @Einav,
It looks like the @DocTag annotation approach won't work until Java 8, because
variable-level annotations are not retained in the binary -- but I need to
access the doc tag name in
AbstractModelBoundPopupPresenterWidget.openDocumentation()
I'm totally bummed because I have the parser reading the @DocTag annotations,
and the code is nice and clean ... but now I can't read them in Java to open
the doc url. :(
Per [1]: "An annotation on a local variable declaration is never retained in
the binary representation."
There is JSR-308, targeted for Java 8, that will fix this. [2]
There is also a JSR-308 preview package [3]
"The Checker Framework compiler in turn uses the 'Type Annotations compiler',
an advance version of the OpenJDK 8 javac compiler that understands type
annotations."
What do you think? I see my options as
1. go back to using a model attribute, model.setDocTag("...", "...")
2. try to use the checker framework
3. push this change out until Java 8 is out :(
[1] http://docs.oracle.com/javase/specs/jls/se7/html/jls-9.html#jls-9.6.3.2
[2] https://jcp.org/en/jsr/detail?id=308
[3]
http://types.cs.washington.edu/checker-framework/current/checkers-manual.html#installation
--
To view, visit http://gerrit.ovirt.org/21052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
