Greg Sheremeta has posted comments on this change.

Change subject: userportal, webadmin: refactor: add model attribute for help 
tags
......................................................................


Patch Set 7:

@Alon,

It works great for creating the ini/json files. But in GWT, when a user clicks 
the help icon, we need to get the URL for that dialog. See the current 
AbstractModelBoundPopupPresenterWidget at the bottom, openDocumentation. We 
need some way to get at the dialog's doctag in there, so it can look up the URL.

-- 
To view, visit http://gerrit.ovirt.org/21052
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to