Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: refactor: add model attribute for help tags ......................................................................
Patch Set 7: The problem is that the dialog-identifying-method we are using should be used for two purposes: 1. generate the template mapping file (by treating the code like a text-file and parsing the identifiers in it) 2. during run-time: tell each dialog which docs URL to open when its "?" icon is clicked. 2 requires that the dialog-identifying-method will be consumable by the GUI code itself; therefore, we cannot use annotations which are supported only in Java 8. Therefore, we must fallback to the way that things are currently implemented, rather than use annotations. -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
