Maor Lipchuk has posted comments on this change.
Change subject: core : Start to remove internal drive mapping
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 72: if (returnValue && diskInfo.isBoot()) {
if you already remove the condition in the patch, there is no need to check the
returnValue.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java
Line 22:
ImagesHandler.getDefaultDiskAlias(vm.getvm_name(),
Integer.toString(vm.getDiskMapCount()));
You can do the same count as you did before only increment it by one.
We can but the suggestion alias should not suggest a duplicate name.
First alias as Disk1 sounds correct to me, if Miki will agree to somthing
different then I don't mind it will be changed, but all the existing aliases
should also be changed as well.
--
To view, visit http://gerrit.ovirt.org/4358
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I020b25f04820b6cbef60764ae8169050bcbdc5bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
